This repository is currently being migrated. It's locked while the migration is in progress.
Divider: Add accessibility notes to divider - #6153
Merged
Merged
Conversation
Update divider component doc: add `web-component: va-divider` and anchors (Example, Usage, Accessibility considerations) in frontmatter; append an Accessibility considerations section that explains decorative vs semantic dividers and when to use `aria-hidden="true"`, with example markup for `va-divider`.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Divider component documentation to better support accessibility guidance and improve page metadata for the documentation site.
Changes:
- Adds
web-component: va-dividerand ananchorslist in the page front matter. - Adds an “Accessibility considerations” section explaining decorative vs. semantic dividers and when to use
aria-hidden="true".
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Delete the 'web-component: va-divider' frontmatter line in src/_components/divider.md to clean up component metadata for the Divider documentation.
derekwang99
approved these changes
Apr 21, 2026
jeana-adhoc
suggested changes
Apr 21, 2026
| - Content structure is already clear through headings or other markup | ||
|
|
||
| ```html | ||
| <va-divider aria-hidden="true"></va-divider> |
Contributor
There was a problem hiding this comment.
@babsdenney - check this - I think the divider is still just html with classes, and not an actual va-component.
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Oh, you are right! I totally trusted the copilot too much on that one. Thank you for finding that. I removed the HTML examples since those aren't really necessary.
Removed examples of HTML for aria-hidden attribute usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update divider component doc: add
web-component: va-dividerand anchors (Example, Usage, Accessibility considerations) in frontmatter; append an Accessibility considerations section that explains decorative vs semantic dividers and when to usearia-hidden="true", with example markup forva-divider.Just a note about dividers - We have an issue to add the plain divider that we should work on in the future.
#1785
Related Issue
Closes #6101
Preview Environment Links
Open Preview Environment